Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove primitive negated goals, crates, and LocalTo predicates #32
Conversation
nikomatsakis
approved these changes
May 3, 2017
Do you want to fix that bug in a separate PR, or roll it in here?
| ty_unify_snapshot, | ||
| krate_unify_snapshot, | ||
| } | ||
| InferenceSnapshot { ty_unify_snapshot } |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
nikomatsakis
May 3, 2017
Member
Hmm, this seems like a pre-existing bug, but shouldn't there be a lifetime_snapshot in this struct too...? I guess I forgot to add one.
nikomatsakis
May 3, 2017
Member
Hmm, this seems like a pre-existing bug, but shouldn't there be a lifetime_snapshot in this struct too...? I guess I forgot to add one.
| ty_unify_snapshot, | ||
| krate_unify_snapshot, | ||
| } | ||
| InferenceSnapshot { ty_unify_snapshot } | ||
| } | ||
| pub fn rollback_to(&mut self, snapshot: InferenceSnapshot) { | ||
| self.ty_unify.rollback_to(snapshot.ty_unify_snapshot); |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
aturon
May 8, 2017
Collaborator
I'm removing snapshots entirely on my current branch, so we should just merge as-is.
|
I'm removing snapshots entirely on my current branch, so we should just merge as-is. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
OK. |
nikomatsakis
merged commit 4195e1b
into
rust-lang-nursery:master
May 8, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
aturon commentedApr 27, 2017
This is all in preparation for the move to a modal world, where negation will be a "derived" operator, and we only need to know whether a given type/trait is "upstream" or not"