Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI Book – Rolling Review – DO NOT MERGE #58

Open
wants to merge 206 commits into
base: pls-review
from

Conversation

@killercup
Copy link
Collaborator

commented Aug 1, 2018

This pull request is not meant to ever be merged.

The book is written like this: New chapters will be added in PRs, where they get a bit of review, and finally get merged into master. Once they land in master, it's hard to leave review comments, though!

This PR is meant to give you a way to review the book and leave comments in an easy way. It shows the diff between master before I added the book and master right now, so it'll always show the full book, and also automatically mark comments as resolved once new content lands in master.

killercup added 30 commits Jul 25, 2018
Ive already added the GITHUB_TOKEN
Just to draft out a possible book structure
mdbook setup and draft of tutorial
Renders nicely on github
These are rendered as separate pages so it makes sense to have an h1 on
each one of them.
More book content
Not meant to replace the book chapter, just wants to provide an
alternative perspective on this in the context of CLI apps.
Tutorial: Draft of Output chapter
Dieter Konrad and others added 9 commits Jan 7, 2019
Dieter Konrad
fix broken link to in-depth chapter
just a little typo fix
Fixes #122
Mention `clap_generate` is for alpha clap v3
…ging-section

Add example of setting env vars in PowerShell
fn main() -> Result<(), io::Error> {
let cfg: ConfyConfig = confy::load("my_app")?;
println!("{:#?}", cfg);

This comment has been minimized.

Copy link
@pickfire

pickfire Mar 28, 2019

I think we could have used dbg!() here instead after the debug have become stable?

in the ideal case when your program succeeds,
it should exit with `0`.

When an error occurs, it gets a bit more complicated, though.

This comment has been minimized.

Copy link
@pickfire

pickfire Mar 28, 2019

Just my two cents, would it be nice to remove the , though here?

deg4uss3r and others added 19 commits Mar 29, 2019
Updated chat with us link to include discord
Philip Conte
fixed typo in output.md
Be explicit about imports
fixed typo
fixed typo
Minor grammar improvement.
howaboutsynergy
typo
Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.