Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upCLI Book – Rolling Review – DO NOT MERGE #58
+4,215
−1
Conversation
killercup
added some commits
Jul 25, 2018
juliangehring
and others
added some commits
Dec 8, 2018
pickfire
reviewed
Mar 28, 2019
| fn main() -> Result<(), io::Error> { | ||
| let cfg: ConfyConfig = confy::load("my_app")?; | ||
| println!("{:#?}", cfg); |
This comment has been minimized.
This comment has been minimized.
pickfire
Mar 28, 2019
I think we could have used dbg!() here instead after the debug have become stable?
pickfire
reviewed
Mar 28, 2019
| in the ideal case when your program succeeds, | ||
| it should exit with `0`. | ||
|
|
||
| When an error occurs, it gets a bit more complicated, though. |
This comment has been minimized.
This comment has been minimized.
deg4uss3r
and others
added some commits
Mar 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
killercup commentedAug 1, 2018
This pull request is not meant to ever be merged.
The book is written like this: New chapters will be added in PRs, where they get a bit of review, and finally get merged into master. Once they land in master, it's hard to leave review comments, though!
This PR is meant to give you a way to review the book and leave comments in an easy way. It shows the diff between master before I added the book and master right now, so it'll always show the full book, and also automatically mark comments as resolved once new content lands in master.