Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd links to each crate on crates.io or github in report html. #152
Conversation
This comment has been minimized.
This comment has been minimized.
|
@colinbankier thanks for the PR! I'm travelling for a couple of days, but am looking forward to trying this out. |
This comment has been minimized.
This comment has been minimized.
|
This looks wonderful, thanks for doing this! |
aidanhs
reviewed
Nov 5, 2017
static/report.js
Outdated
| @@ -146,7 +147,7 @@ function insertResults(results) { | |||
|
|
|||
| let row = ` | |||
| <div class="${res}"> | |||
| <span>${name}</span> | |||
| <span><a href="${url}" target="_blank">${name}</a></span> | |||
This comment has been minimized.
This comment has been minimized.
aidanhs
Nov 5, 2017
•
Member
Can you add rel="noopener" to the link (per this)? The links are on trustworthy domains atm, but I want to make sure it's ok in the future. (firefox supports noopener too now)
This comment has been minimized.
This comment has been minimized.
|
Aside from the one minor comment, I'm ready to merge! |
This comment has been minimized.
This comment has been minimized.
|
Added rel=noopener to link :) |
aidanhs
merged commit 58e65e5
into
rust-lang-nursery:master
Nov 10, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
This comment has been minimized.
This comment has been minimized.
|
This is live in the latest reports (https://cargobomb-reports.s3.amazonaws.com/pr-45225-3/index.html) - thanks again @colinbankier! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
colinbankier commentedOct 31, 2017
Addresses #118.
This turns the name of each crate in the report into a link to either the crates.io page for that version, or the github source at that sha.