Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upSwitch build environment to rustops/crates-build-env #376
Conversation
This comment has been minimized.
This comment has been minimized.
|
@bors r+ |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Dec 15, 2018
This comment has been minimized.
This comment has been minimized.
|
|
pietroalbini
added some commits
Dec 13, 2018
pietroalbini
force-pushed the
pietroalbini:crates-build-env
branch
from
06aa663
to
5f76a0e
Dec 16, 2018
This comment has been minimized.
This comment has been minimized.
|
@bors r+ Why do I even bother pushing code at midnight... |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Dec 16, 2018
This comment has been minimized.
This comment has been minimized.
|
@bors retry |
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Dec 16, 2018
This comment has been minimized.
This comment has been minimized.
|
|
bors
merged commit 5f76a0e
into
rust-lang-nursery:master
Dec 16, 2018
pietroalbini
deleted the
pietroalbini:crates-build-env
branch
Dec 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
pietroalbini commentedDec 15, 2018
This PR switches the build environment used by Crater to the Docker image built in the rust-ops/crates-build-env repository. Instead of installing GTK and all the suggested stuff and hoping for the best, the new image installs a curated set of packages built over time by the docs.rs developers (thanks @onur!) which weights about 3GB (1GB compressed download).
The image is also downloaded from Docker Hub instead of being built locally, and it's automatically updated every time a run is started. This also means
prepare-localis no longer needed if you only want to execute a run (creating new ones still requires the command).This PR also removes the distinction between the mini and the full images, since the new image has a reasonable size for local development and it's prebuilt.