Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upStrip missing examples from crates #378
Conversation
Zeegomo
added some commits
Dec 13, 2018
This comment has been minimized.
This comment has been minimized.
|
Not sure of what to do with clippy error, is changing signature into |
This comment has been minimized.
This comment has been minimized.
|
That's a false positive (technically it's correct, but whatever), just allow it for the function. |
pietroalbini
requested changes
Dec 19, 2018
|
This looks good, thanks! Just a small thing I'd like you to address before merging the PR. |
pietroalbini
approved these changes
Dec 19, 2018
This comment has been minimized.
This comment has been minimized.
|
Thanks! @bors r+ |
This comment has been minimized.
This comment has been minimized.
|
|
bors
added a commit
that referenced
this pull request
Dec 19, 2018
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
bors
merged commit acef0c4
into
rust-lang-nursery:master
Dec 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Zeegomo commentedDec 18, 2018
fix #309
Check existence for every test and example specified in Cargo.toml