Skip to content

/crater

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor log handling #379

Merged
merged 5 commits into from Dec 19, 2018

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@pietroalbini @bors
@pietroalbini
Copy link
Member

pietroalbini commented Dec 19, 2018

This PR refactors log handling to use the log and env_logger crates instead of slog. They provide more compatibility with the rest of the ecosystem, and they're more flexible to work with.

The refactor also prepends the logs generated during the prepare step to a crate's build log, so it's easier to investigate failures in that step.
@pietroalbini

This comment has been minimized.

Sign in to view
Copy link
Member Author

pietroalbini commented Dec 19, 2018

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Collaborator

bors commented Dec 19, 2018

📌 Commit faae2db has been approved by pietroalbini
@bors

This comment has been minimized.

Sign in to view
Copy link
Collaborator

bors commented Dec 19, 2018

⌛️ Testing commit faae2db with merge 5a002dc...

bors added a commit that referenced this pull request Dec 19, 2018

@bors
Auto merge of #379 - pietroalbini:logs, r=pietroalbini 
Refactor log handling

This PR refactors log handling to use the `log` and `env_logger` crates instead of `slog`. They provide more compatibility with the rest of the ecosystem, and they're more flexible to work with.

The refactor also prepends the logs generated during the prepare step to a crate's build log, so it's easier to investigate failures in that step.
Loading status checks…
5a002dc
@bors

This comment has been minimized.

Sign in to view
Copy link
Collaborator

bors commented Dec 19, 2018

💔 Test failed - status-travis

pietroalbini added some commits Dec 19, 2018

@pietroalbini
logs: switch from slog to log and env_logger
Verified
This commit was signed with a verified signature.
@pietroalbini pietroalbini Pietro Albini
GPG key ID: 3E06ABE80BAAF19C Learn about signing commits
b2e5187
@pietroalbini
db: log executed queries
Verified
This commit was signed with a verified signature.
@pietroalbini pietroalbini Pietro Albini
GPG key ID: 3E06ABE80BAAF19C Learn about signing commits
25031f3
@pietroalbini
runner: include prepare step in the logs
Verified
This commit was signed with a verified signature.
@pietroalbini pietroalbini Pietro Albini
GPG key ID: 3E06ABE80BAAF19C Learn about signing commits
Loading status checks…
4cc86bb

@pietroalbini pietroalbini force-pushed the pietroalbini:logs branch from faae2db to 4cc86bb Dec 19, 2018

@pietroalbini

This comment has been minimized.

Sign in to view
Copy link
Member Author

pietroalbini commented Dec 19, 2018

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Collaborator

bors commented Dec 19, 2018

📌 Commit 4cc86bb has been approved by pietroalbini
@bors

This comment has been minimized.

Sign in to view
Copy link
Collaborator

bors commented Dec 19, 2018

⌛️ Testing commit 4cc86bb with merge ab9840e...

bors added a commit that referenced this pull request Dec 19, 2018

@bors
Auto merge of #379 - pietroalbini:logs, r=pietroalbini 
Refactor log handling

This PR refactors log handling to use the `log` and `env_logger` crates instead of `slog`. They provide more compatibility with the rest of the ecosystem, and they're more flexible to work with.

The refactor also prepends the logs generated during the prepare step to a crate's build log, so it's easier to investigate failures in that step.
Loading status checks…
ab9840e
@bors

This comment has been minimized.

Sign in to view
Copy link
Collaborator

bors commented Dec 19, 2018

💔 Test failed - status-travis

pietroalbini added some commits Dec 19, 2018

@pietroalbini
logs: setup logging during a few tests
Verified
This commit was signed with a verified signature.
@pietroalbini pietroalbini Pietro Albini
GPG key ID: 3E06ABE80BAAF19C Learn about signing commits
1d744e3
@pietroalbini
tests: test check_config using stderr instead of stdout
Verified
This commit was signed with a verified signature.
@pietroalbini pietroalbini Pietro Albini
GPG key ID: 3E06ABE80BAAF19C Learn about signing commits
Loading status checks…
a0415eb
@pietroalbini

This comment has been minimized.

Sign in to view
Copy link
Member Author

pietroalbini commented Dec 19, 2018

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Collaborator

bors commented Dec 19, 2018

📌 Commit a0415eb has been approved by pietroalbini
@bors

This comment has been minimized.

Sign in to view
Copy link
Collaborator

bors commented Dec 19, 2018

⌛️ Testing commit a0415eb with merge 9dbf400...

bors added a commit that referenced this pull request Dec 19, 2018

@bors
Auto merge of #379 - pietroalbini:logs, r=pietroalbini 
Refactor log handling

This PR refactors log handling to use the `log` and `env_logger` crates instead of `slog`. They provide more compatibility with the rest of the ecosystem, and they're more flexible to work with.

The refactor also prepends the logs generated during the prepare step to a crate's build log, so it's easier to investigate failures in that step.
Loading status checks…
9dbf400
@bors

This comment has been minimized.

Sign in to view
Copy link
Collaborator

bors commented Dec 19, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: pietroalbini
Pushing 9dbf400 to master...

@bors bors merged commit a0415eb into rust-lang-nursery:master Dec 19, 2018
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.