Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upReport agent crashes to the server #392
Conversation
Zeegomo
added some commits
Jan 22, 2019
pietroalbini
requested changes
Jan 23, 2019
|
Great PR, thanks! Left a minor style comment. Can you also add some docs about the new endpoint to |
src/agent/mod.rs Outdated
pietroalbini
requested changes
Jan 23, 2019
docs/agent-http-api.md Outdated
docs/agent-http-api.md Outdated
Zeegomo
added some commits
Jan 24, 2019
This comment has been minimized.
This comment has been minimized.
|
Thanks! This looks great! @bors r+ |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Jan 24, 2019
pietroalbini
approved these changes
Jan 24, 2019
This comment has been minimized.
This comment has been minimized.
|
|
bors
merged commit d891acb
into
rust-lang-nursery:master
Jan 24, 2019
1 check passed
homu
Test successful
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Zeegomo commentedJan 23, 2019
•
edited
fixed #246
Any error encountered by the agent will be reported to the server that will post it to the relevant GitHub thread. Add new
failedexperiment status and commandretryto queue again jobs marked as failed