Skip to content

/crater

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically detect and fill in try builds #404

Merged
merged 2 commits into from Mar 6, 2019

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@pietroalbini @bors
@pietroalbini
Copy link
Member

pietroalbini commented Mar 6, 2019

This PR implements automatic detection of the latest try build in a PR, using those as the default when no try build is specified in the run command:

demo

pietroalbini added some commits Mar 6, 2019

@pietroalbini
server.github: put GitHubApi behind a trait
Verified
This commit was signed with a verified signature.
@pietroalbini pietroalbini Pietro Albini
GPG key ID: 3E06ABE80BAAF19C Learn about signing commits
485d57e
@pietroalbini
server: automatically detect try builds
Verified
This commit was signed with a verified signature.
@pietroalbini pietroalbini Pietro Albini
GPG key ID: 3E06ABE80BAAF19C Learn about signing commits
Loading status checks…
fba4443
@pietroalbini

This comment has been minimized.

Sign in to view
Copy link
Member Author

pietroalbini commented Mar 6, 2019

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Collaborator

bors commented Mar 6, 2019

📌 Commit fba4443 has been approved by pietroalbini
@bors

This comment has been minimized.

Sign in to view
Copy link
Collaborator

bors commented Mar 6, 2019

⌛️ Testing commit fba4443 with merge 5d2365b...

bors added a commit that referenced this pull request Mar 6, 2019

@bors
Auto merge of #404 - pietroalbini:recognize-try-builds, r=pietroalbini 
Automatically detect and fill in try builds

This PR implements automatic detection of the latest try build in a PR, using those as the default when no try build is specified in the `run` command:

![demo](https://user-images.githubusercontent.com/2299951/53890036-bec51500-4027-11e9-8642-d8c6ab0a67ed.png)
Loading status checks…
5d2365b
@bors

This comment has been minimized.

Sign in to view
Copy link
Collaborator

bors commented Mar 6, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: pietroalbini
Pushing 5d2365b to master...

@bors bors merged commit fba4443 into rust-lang-nursery:master Mar 6, 2019
1 check passed

1 check passed

homu Test successful
Details

@pietroalbini pietroalbini deleted the pietroalbini:recognize-try-builds branch Mar 6, 2019

@pietroalbini

This comment has been minimized.

Sign in to view
Copy link
Member Author

pietroalbini commented Mar 6, 2019

Deployed this!

cc @rust-lang-nursery/compiler, you probably want to know about this :)

@Mark-Simulacrum Mark-Simulacrum referenced this pull request Mar 9, 2019

Closed

Automatically get toolchans from PR runs in craterbot #250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.