Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAll links broken on https://rust-lang-nursery.github.io/edition-guide/rust-2018/edition-changes.html #138
Comments
This comment has been minimized.
This comment has been minimized.
|
This shouldn’t be published to github pages anymore. It lives under doc.rust-Lang.org these days
… On Jan 22, 2019, at 9:07 PM, Brian Anderson ***@***.***> wrote:
Every link here takes me to 404 - it creates URLS containing incorrect "rust-2018/rust-2018" paths.
This looks pretty bad and it's hopefully an easy fix.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
This comment has been minimized.
This comment has been minimized.
|
Aha. Thanks @steveklabnik. I don't see how to get to it from https://doc.rust-lang.org/ though. |
This comment has been minimized.
This comment has been minimized.
|
In addition to ceasing publication on github.io the description of the repo needs to change and the README. They both contain the github.io link. |
This comment has been minimized.
This comment has been minimized.
|
github.io probably needs a redirect too. Yeah, the first search hit I get is for the github.io version. |
This comment has been minimized.
This comment has been minimized.
siddharthasahu
commented
Jan 29, 2019
|
They are also not the same versions. Eg. https://rust-lang-nursery.github.io/edition-guide/rust-2018/edition-changes.html does not exist on the stable version. cc #76 |
This comment has been minimized.
This comment has been minimized.
|
How and when is this guide published to https://doc.rust-lang.org/ ? |
This comment has been minimized.
This comment has been minimized.
|
@dwijnand every rust release, we update the submodule, and so it should be updated like any other docs; changes from here will take between 7 and 13 weeks to make it to the main doc.rust-lang.org page. |
This comment has been minimized.
This comment has been minimized.
|
I realise your time is limited, but wouldn't it be better if https://doc.rust-lang.org/edition-guide/ were a redirect to (or proxy of) https://rust-lang-nursery.github.io/edition-guide/, with the latest and greatest fixes that have landed? The offline rust distributions will have some slightly older/stale version and, if need be, https://doc.rust-lang.org/stable/edition-guide can host that version of the guide, no? |
This comment has been minimized.
This comment has been minimized.
|
Sure, that’s why this bug is open.
… On Jan 29, 2019, at 3:39 PM, Dale Wijnand ***@***.***> wrote:
I realise your time is limited, but wouldn't it be better if https://doc.rust-lang.org/edition-guide/ were a redirect to (or proxy of) https://rust-lang-nursery.github.io/edition-guide/, with the latest and greatest fixes that have landed? The offline rust distributions will have some slightly older/stale version and, if need be, https://doc.rust-lang.org/stable/edition-guide can host that version of the guide, no?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
This comment has been minimized.
This comment has been minimized.
|
Err sorry, no. I mean, in some sense, it would be good, but it’s not how we distribute our docs. This isn’t possible with today’s setup.
There are also advantages to that setup; we don’t want everyone to point to the latest and greatest, as it may have stabilized in nightly but not yet hit stable.
(This bug is about redirects the other way.)
… On Jan 29, 2019, at 4:55 PM, Steve Klabnik ***@***.***> wrote:
Sure, that’s why this bug is open.
> On Jan 29, 2019, at 3:39 PM, Dale Wijnand ***@***.***> wrote:
>
> I realise your time is limited, but wouldn't it be better if https://doc.rust-lang.org/edition-guide/ were a redirect to (or proxy of) https://rust-lang-nursery.github.io/edition-guide/, with the latest and greatest fixes that have landed? The offline rust distributions will have some slightly older/stale version and, if need be, https://doc.rust-lang.org/stable/edition-guide can host that version of the guide, no?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or mute the thread.
|
ehuss
added a commit
to ehuss/edition-guide
that referenced
this issue
Feb 28, 2019
This comment has been minimized.
This comment has been minimized.
|
Links are now fixed as of #152, and a redirect has been established with #150. The doc.rust-lang.org website should update once rust-lang/rust#58800 is merged and a new nightly is published. |
brson commentedJan 23, 2019
Every link here takes me to 404 - it creates URLS containing incorrect "rust-2018/rust-2018" paths.
This looks pretty bad and it's hopefully an easy fix.