Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All links broken on https://rust-lang-nursery.github.io/edition-guide/rust-2018/edition-changes.html #138

Closed
brson opened this Issue Jan 23, 2019 · 11 comments

Comments

Projects
None yet
5 participants
@brson
Copy link
Contributor

brson commented Jan 23, 2019

Every link here takes me to 404 - it creates URLS containing incorrect "rust-2018/rust-2018" paths.

This looks pretty bad and it's hopefully an easy fix.

@steveklabnik

This comment has been minimized.

Copy link
Member

steveklabnik commented Jan 23, 2019

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Jan 23, 2019

Aha. Thanks @steveklabnik.

I don't see how to get to it from https://doc.rust-lang.org/ though.

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Jan 23, 2019

In addition to ceasing publication on github.io the description of the repo needs to change and the README. They both contain the github.io link.

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Jan 23, 2019

github.io probably needs a redirect too. Yeah, the first search hit I get is for the github.io version.

@siddharthasahu

This comment has been minimized.

Copy link

siddharthasahu commented Jan 29, 2019

They are also not the same versions. Eg. https://rust-lang-nursery.github.io/edition-guide/rust-2018/edition-changes.html does not exist on the stable version.

cc #76

@dwijnand

This comment has been minimized.

Copy link
Contributor

dwijnand commented Jan 29, 2019

How and when is this guide published to https://doc.rust-lang.org/ ?

@steveklabnik

This comment has been minimized.

Copy link
Member

steveklabnik commented Jan 29, 2019

@dwijnand every rust release, we update the submodule, and so it should be updated like any other docs; changes from here will take between 7 and 13 weeks to make it to the main doc.rust-lang.org page.

@dwijnand

This comment has been minimized.

Copy link
Contributor

dwijnand commented Jan 29, 2019

I realise your time is limited, but wouldn't it be better if https://doc.rust-lang.org/edition-guide/ were a redirect to (or proxy of) https://rust-lang-nursery.github.io/edition-guide/, with the latest and greatest fixes that have landed? The offline rust distributions will have some slightly older/stale version and, if need be, https://doc.rust-lang.org/stable/edition-guide can host that version of the guide, no?

@steveklabnik

This comment has been minimized.

Copy link
Member

steveklabnik commented Jan 29, 2019

@steveklabnik

This comment has been minimized.

Copy link
Member

steveklabnik commented Jan 29, 2019

ehuss added a commit to ehuss/edition-guide that referenced this issue Feb 28, 2019

Redirect gh-pages to doc.rust-lang.org.
This redirects to the nightly copy with the intent that people were coming here
for the up-to-date version. This includes fragment-preserving redirects.

cc rust-lang-nursery#76, rust-lang-nursery#138
@ehuss

This comment has been minimized.

Copy link
Collaborator

ehuss commented Feb 28, 2019

Links are now fixed as of #152, and a redirect has been established with #150. The doc.rust-lang.org website should update once rust-lang/rust#58800 is merged and a new nightly is published.

@ehuss ehuss closed this Feb 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.