Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the edition guide to a more prominent location #76

Closed
Centril opened this Issue Aug 6, 2018 · 7 comments

Comments

Projects
None yet
8 participants
@Centril
Copy link
Collaborator

Centril commented Aug 6, 2018

We should eventually move the guide out of the https://rust-lang-nursery.github.io/ URL and give it a more official-looking, short and sweet URL instead.

We decided that we will punt on this for Preview 2; but we should do this for Release Candidate 1.

A suggested URL for the whole edition is https://rust-lang.org/edition/ and https://rust-lang.org/edition/2018/ then goes to the 2018 page.

We can also move it to https://docs.rust-lang.org/edition/

@Centril Centril added this to the Release Candidate milestone Aug 6, 2018

@orium

This comment has been minimized.

Copy link

orium commented Aug 18, 2018

Note that when this is done some urls in cargo will need to be updated. At the time of this comment there are two references to rust-lang-nursery.github.io:

orium@laptop-orion cargo % rp rust-lang-nursery.github.io
src/cargo/util/diagnostic_server.rs
174:  https://rust-lang-nursery.github.io/edition-guide/editions/transitioning-your-code-to-a-new-edition.html
196:  https://rust-lang-nursery.github.io/edition-guide/editions/transitioning-your-code-to-a-new-edition.html

steveklabnik added a commit that referenced this issue Sep 18, 2018

Remove explicit link to self
in preparation for #76. this just linked to itself anyway, so let's
not link.

@steveklabnik steveklabnik removed this from the Release Candidate milestone Sep 18, 2018

@steveklabnik

This comment has been minimized.

Copy link
Member

steveklabnik commented Sep 18, 2018

This is not happening as part of the release candidate, so de-milestoning.

@tmandry

This comment has been minimized.

Copy link

tmandry commented Oct 18, 2018

Will this happen before release? It looks like there was some mention on Discord, but no formal decision made.

At least one rustc PR (rust-lang/rust#55185) includes a guide URL; we're not sure if it's going to change.

@dwijnand

This comment has been minimized.

Copy link
Contributor

dwijnand commented Jan 18, 2019

Interestingly hasn't changed with the 1.32 release.

@siddharthasahu

This comment has been minimized.

Copy link

siddharthasahu commented Jan 29, 2019

bors bot added a commit to rust-embedded/embedonomicon that referenced this issue Jan 31, 2019

Merge #34
34: Added missing link to edition 2018 guide r=therealprof a=caemor

It looked like the link to the edition guide was missing. But it might have been intentional because the edition guide might be moved to doc.rust-lang.org later on (rust-lang-nursery/edition-guide#76) :-)

Co-authored-by: Chris <11088935+caemor@users.noreply.github.com>

ehuss added a commit to ehuss/edition-guide that referenced this issue Feb 28, 2019

Redirect gh-pages to doc.rust-lang.org.
This redirects to the nightly copy with the intent that people were coming here
for the up-to-date version. This includes fragment-preserving redirects.

cc rust-lang-nursery#76, rust-lang-nursery#138
@ehuss

This comment has been minimized.

Copy link
Collaborator

ehuss commented Feb 28, 2019

The guide now lives at https://doc.rust-lang.org/edition-guide/. The latest version will be published at https://doc.rust-lang.org/nightly/edition-guide/, and should be live soon.

@siddharthasahu I updated the minimum version for that page in #149. I'm not sure if that's the change you were thinking of, feel free to leave comments on that PR.

@ehuss ehuss closed this Feb 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.