Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upExplicitly mention not passing prepare flag after switching to new edition #69
Conversation
This comment has been minimized.
This comment has been minimized.
|
Thanks for the PR! I think this might be most appropriate in the section below though? After the edition is turned on we don't necessarily recommend you keep running |
This comment has been minimized.
This comment has been minimized.
|
@alexcrichton How does it look now? |
alexcrichton
merged commit 8871e7a
into
rust-lang-nursery:master
Jul 29, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
|
|
johnthagen
deleted the
johnthagen:patch-1
branch
Jul 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
johnthagen commentedJul 28, 2018
Related to rust-lang/cargo#5778.
Based on feedback from the internals thread, hopefully this clarification will help people realize not to pass the
--prepare-forflag after they've already transitioned to the new edition.Hopefully removes a paper cut when others test out this feature.