Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upMigrate to using `cargo fix --edition-idioms` #70
Conversation
alexcrichton
referenced this pull request
Jul 31, 2018
Closed
Should the rust_2018_idioms lint group be mentioned in documentation? #52679
This comment has been minimized.
This comment has been minimized.
|
DON'T MERGE YET! This PR is awaiting the stuff mentioned above to be merged into Cargo. |
This comment has been minimized.
This comment has been minimized.
|
Ah yes, sorry! This is blocked on rust-lang/cargo#5843 making its way into nightlies. |
This comment has been minimized.
This comment has been minimized.
|
Note to self: Once this is merged, #19 should be rendered moot so we can close that then. |
alexcrichton
force-pushed the
alexcrichton:idioms
branch
from
aa81942
to
86542ae
Aug 3, 2018
alexcrichton
changed the title
Migrate to using `cargo fix --idioms`
Migrate to using `cargo fix --edition-idioms`
Aug 3, 2018
This comment has been minimized.
This comment has been minimized.
|
Everything is now landed in rust-lang/rust and a nightly is one the way out, so merging! |
alexcrichton
merged commit 01e2f7b
into
rust-lang-nursery:master
Aug 3, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
alexcrichton
deleted the
alexcrichton:idioms
branch
Aug 3, 2018
Centril
referenced this pull request
Aug 3, 2018
Closed
Suggest/Talk about --all-targets and feature gating #19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
alexcrichton commentedJul 31, 2018
This'll be a new flag being added to Cargo to help transitioning to the idioms
of the 2018 edition.
At the same time this removes the
+nightlyinvocations from Cargo commands,removes
--all-targetsas it's the default, and finally removes--all-featuresas the default of--all-targetsshould be enough.