Remove the foreign link description and forward to the foreign error #16

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@cramertj
Contributor

cramertj commented Aug 3, 2016

Fix #15

@brson

This comment has been minimized.

Show comment
Hide comment
@brson

brson Aug 4, 2016

Contributor

Thanks @cramertj. I posted a question to the urlo error-chain thread asking what people thought of the breakage caused by removing this.

As I was writing it though my brain was telling me, 'come on just do it backwards compatibly'. How hard do you think it would be to make the macro optionally parse that string and just discard it?

Contributor

brson commented Aug 4, 2016

Thanks @cramertj. I posted a question to the urlo error-chain thread asking what people thought of the breakage caused by removing this.

As I was writing it though my brain was telling me, 'come on just do it backwards compatibly'. How hard do you think it would be to make the macro optionally parse that string and just discard it?

@cramertj

This comment has been minimized.

Show comment
Hide comment
@cramertj

cramertj Aug 4, 2016

Contributor

Just discard it? It wouldn't be hard at all, but it would prevent users from discovering the change to the underlying library functionality. Users could potentially continue working with the faulty assumption that their display string was being used, which I think is worse than the minimal API breakage. Considering they're already bumping the version in order for the API change to occur, it doesn't seem like too much to ask that they just delete the description string.

Contributor

cramertj commented Aug 4, 2016

Just discard it? It wouldn't be hard at all, but it would prevent users from discovering the change to the underlying library functionality. Users could potentially continue working with the faulty assumption that their display string was being used, which I think is worse than the minimal API breakage. Considering they're already bumping the version in order for the API change to occur, it doesn't seem like too much to ask that they just delete the description string.

@brson

This comment has been minimized.

Show comment
Hide comment
@brson

brson Aug 6, 2016

Contributor

Rebased and merged.

Contributor

brson commented Aug 6, 2016

Rebased and merged.

@brson brson closed this Aug 6, 2016

@cramertj cramertj deleted the cramertj:rm-foreign-link-description branch Aug 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment