Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign uperror-chain deprecation #181
Comments
Yamakaky
changed the title
`error-chain` deprecation
error-chain deprecation
Mar 7, 2018
This comment has been minimized.
This comment has been minimized.
leoschwarz
commented
Mar 29, 2018
|
Hi. Thanks for your update.
I think the biggest problem I see with this, is that the paradigms of both crates are a bit different, and in general going from error-chain to failure has involved rethinking my error handling. What's usually happened when using error-chain for me is that I end up creating My personal experience is that failure leads me to writing cleaner error handling, however I have yet to try how well it proves for debugging. Because on of the biggest selling points of error-chain for me has always been, use it everywhere (which is really easy) and you will get backtraces everywhere when you need them. |
This comment has been minimized.
This comment has been minimized.
Yamakaky
commented
Mar 31, 2018
|
Yeah, I didn't mean a 1-1 feature mapping. I meant that the use-cases are covered. |
adrian-budau
referenced this issue
Jun 25, 2018
Open
`std::error::Error` is not implemented for `input_stream::Error` #1
This comment has been minimized.
This comment has been minimized.
|
Should this discussion be revisited now that the path forward for |
This comment has been minimized.
This comment has been minimized.
|
I feel like the issue here is now more complex as error is now being fixed in the stdlib so it's not even clear what the failure story is going to be going forward. |
Yamakaky commentedMar 7, 2018
Hey,
error-chain's maintainer here.I have not been as active on error-chain maintenance as I should have (cf all the issues and PR). I'm also working less with Rust these times (I keep an eye on it though). Since it's not perfect anyway (rust-lang-nursery/error-chain#190) and
failureis an improvement onerror-chain, I guess the best way to go would be to deprecate it and go fullfailure. It could be done with the 1.0failurerelease.I see a few points that should be solved before the full deprecation:
error-chain. I'm thinking something like "if you do this inerror-chain, replace it by that infailure.error-chainis supported byfailure.Do you think of it?
Not sure who should be included in this discussion.