Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upnew `crate` keyword breaks derive #225
Comments
This comment has been minimized.
This comment has been minimized.
|
I believe the fix will be to upgrade to a newer version of Syn which supports this newer syntax. |
This comment has been minimized.
This comment has been minimized.
|
This has become more relevant now with the recent call to arms to test the module system changes |
This comment has been minimized.
This comment has been minimized.
|
Ah, I think I see what's going on. This has been fixed, but the fix is not released because the next planned update to 0.1.X was to have it use a compatibility shim over 1.0.0 (which got delayed). This is a shame; perhaps some recent fixes like this one should be backported onto something more closely resembling the 0.1.1 release. |
This comment has been minimized.
This comment has been minimized.
|
@mitsuhiko was curious, do you know if there's a plan for releasing failure 0.1.2 with a fix like this? |
This comment has been minimized.
This comment has been minimized.
|
@alexcrichton yes, but i do not yet have rights to crates.io |
This comment has been minimized.
This comment has been minimized.
|
I'm going to see if I can downgrade the current master so it does not need the 1.0 version, otherwise I might just fork it off from an older revision for now. |
This comment has been minimized.
This comment has been minimized.
|
@withoutboats ping on this, mind giving @mitsuhiko publish rights? |
This comment has been minimized.
This comment has been minimized.
|
There is a pending release in #229 now. I need to do a lot of testing though (ideally a crater run but I do not know how to achieve that) as it's a merged version of 0.1 and 1.0. |
This comment has been minimized.
This comment has been minimized.
|
This is fixed on master. I'm going to close this issue for now. |
kazcw commentedJun 28, 2018
This panics ("failed to parse derive input"):
This works: