Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new `crate` keyword breaks derive #225

Closed
kazcw opened this Issue Jun 28, 2018 · 9 comments

Comments

Projects
None yet
5 participants
@kazcw
Copy link

kazcw commented Jun 28, 2018

This panics ("failed to parse derive input"):

#[derive(Fail)]                                                                                                  
crate struct Foo;

This works:

#[derive(Fail)]                                                                                                  
pub(crate) struct Foo;
@dtolnay

This comment has been minimized.

Copy link
Member

dtolnay commented Jul 12, 2018

I believe the fix will be to upgrade to a newer version of Syn which supports this newer syntax.

@ExpHP

This comment has been minimized.

Copy link
Contributor

ExpHP commented Jul 24, 2018

This has become more relevant now with the recent call to arms to test the module system changes

@ExpHP

This comment has been minimized.

Copy link
Contributor

ExpHP commented Jul 24, 2018

Ah, I think I see what's going on. This has been fixed, but the fix is not released because the next planned update to 0.1.X was to have it use a compatibility shim over 1.0.0 (which got delayed).

This is a shame; perhaps some recent fixes like this one should be backported onto something more closely resembling the 0.1.1 release.

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Jul 26, 2018

@mitsuhiko was curious, do you know if there's a plan for releasing failure 0.1.2 with a fix like this?

@mitsuhiko

This comment has been minimized.

Copy link
Member

mitsuhiko commented Jul 26, 2018

@alexcrichton yes, but i do not yet have rights to crates.io

@mitsuhiko

This comment has been minimized.

Copy link
Member

mitsuhiko commented Jul 26, 2018

I'm going to see if I can downgrade the current master so it does not need the 1.0 version, otherwise I might just fork it off from an older revision for now.

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Jul 26, 2018

@withoutboats ping on this, mind giving @mitsuhiko publish rights?

@mitsuhiko

This comment has been minimized.

Copy link
Member

mitsuhiko commented Jul 26, 2018

There is a pending release in #229 now. I need to do a lot of testing though (ideally a crater run but I do not know how to achieve that) as it's a merged version of 0.1 and 1.0.

@mitsuhiko

This comment has been minimized.

Copy link
Member

mitsuhiko commented Jul 27, 2018

This is fixed on master. I'm going to close this issue for now.

@mitsuhiko mitsuhiko closed this Jul 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.