New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak in downcast for older rust versions (#262). #265

Merged
merged 1 commit into from Oct 20, 2018

Conversation

Projects
None yet
3 participants
@rustonaut
Copy link
Contributor

rustonaut commented Oct 2, 2018

The previous fix didn't work for all supported
rust versions as it was relying on the alloc fn's.

Fix memory leak in downcast for older rust versions (#262).
The previous fix didn't work for all supported
rust versions as it was relying on the alloc fn's.
@rustonaut

This comment has been minimized.

Copy link
Contributor

rustonaut commented Oct 2, 2018

As a side note Deref on Box is a bit special, if I'm not wrong this won't work
with any custom type. Through custom types tend to provide a into_inner method
which Box doesn't provide.

@jonas-schievink

This comment has been minimized.

Copy link

jonas-schievink commented Oct 19, 2018

ping @mitsuhiko - this might be a better fix for #261

@mitsuhiko mitsuhiko merged commit 47c4ce5 into rust-lang-nursery:master Oct 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mitsuhiko

This comment has been minimized.

Copy link
Collaborator

mitsuhiko commented Oct 20, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment