New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement `Error` and `Display` for `SharedError` when possible #686

Merged
merged 1 commit into from Dec 31, 2017

Conversation

Projects
None yet
2 participants
@lo48576
Copy link
Contributor

lo48576 commented Dec 30, 2017

impl Error for SharedError<E> enables us to use some useful
functionalities such as
impl<E: Error+Send+Sync> From<E> for Box<Error+Send+Sync>.

impl Display for SharedError<E> is required by Error trait.

Implement `Error` and `Display` for `SharedError` when possible
`impl Error for SharedError<E>` enables us to use some useful
functionalities such as
`impl<E: Error+Send+Sync> From<E> for Box<Error+Send+Sync>`.

`impl Display for SharedError<E>` is required by `Error` trait.

@alexcrichton alexcrichton merged commit 9509d4d into rust-lang-nursery:master Dec 31, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Dec 31, 2017

Thanks!

@lo48576 lo48576 deleted the lo48576:impl-error-for-shared-error branch Dec 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment