Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upSwitch lazy_static over to mutable statics instead of UnsafeCell on nightly #55
Conversation
KodrAus
referenced this pull request
Sep 26, 2017
Merged
Enable the const_unsafe_cell_new feature flag for nightly #84
Kimundi
force-pushed the
destructor_drop
branch
from
4fe25de
to
a308da1
Nov 13, 2017
Kimundi
changed the title
WIP: Switch lazy_static over to mutable statics instead of UnsafeCell on nightly
Switch lazy_static over to mutable statics instead of UnsafeCell on nightly
Nov 13, 2017
This comment has been minimized.
This comment has been minimized.
Kimundi
added some commits
Nov 13, 2017
Kimundi
force-pushed the
destructor_drop
branch
from
3e1f63e
to
8fff063
Nov 13, 2017
This comment has been minimized.
This comment has been minimized.
|
Alright, thanks! |
Kimundi
merged commit cd632cb
into
master
Nov 20, 2017
Kimundi
deleted the
destructor_drop
branch
Nov 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Kimundi commentedNov 16, 2016
rust-lang/rfcs#1440 got merged, so we can now get rid of the UnsafeCell in favor of directly having a drop type in a mutable static.
However, since the current
UnsafeCellimpl got also legitimized by the RFC, the current plan is to not merge this PR until either thedrop_types_in_constfeature gets stabilized, or is at least old enough to not require the most current version of the compiler.