Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate to support Rust 1.18 visibility restrictions (see #80) #81
Conversation
This comment has been minimized.
This comment has been minimized.
|
@Kimundi do you have any thoughts on this? |
Kimundi
merged commit 7dd4c01
into
rust-lang-nursery:master
Sep 28, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
|
Sorry for the late response. This patch looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
alekratz commentedJul 7, 2017
•
edited
Obviously, if there's something dire that needs to be changed or fixed, please let me know (or fix it). The one concern I had was the weirdness that
pub(in module)produces with the macros, because it adds an extra argument. I've added a special rule to__lazy_static_internalthat allows for a workaround.