Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upEnable the const_unsafe_cell_new feature flag for nightly #84
Conversation
This comment has been minimized.
This comment has been minimized.
|
Thanks @jedisct1! This depends on mvdnes/spin-rs#42 |
joshlf
referenced this pull request
Sep 19, 2017
Open
CI: Build for more platforms and compilers #73
This comment has been minimized.
This comment has been minimized.
|
This looks good to me. @Kimundi are we ok to merge this and push out a point release? |
This comment has been minimized.
This comment has been minimized.
|
Another fix for this I think would be #55 which removes the need for this feature flag. |
Kimundi
merged commit 4daab9f
into
rust-lang-nursery:master
Sep 28, 2017
1 check passed
This comment has been minimized.
This comment has been minimized.
|
Looks good, thanks! |
This comment has been minimized.
This comment has been minimized.
joshlf
commented
Sep 28, 2017
|
Looks like this might not be sufficient - since the version of |
This comment has been minimized.
This comment has been minimized.
|
It seems pretty expected that people may have to update dependencies to fix bugs? |
This comment has been minimized.
This comment has been minimized.
joshlf
commented
Sep 28, 2017
|
Well right now, this will just show itself as a compilation failure - it wouldn't be obvious that updating to a newer version would fix things. If we changed the dependency to |
jedisct1 commentedSep 18, 2017
No description provided.