Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the const_unsafe_cell_new feature flag for nightly #84

Merged
merged 1 commit into from Sep 28, 2017

Conversation

Projects
None yet
5 participants
@jedisct1
Copy link
Contributor

jedisct1 commented Sep 18, 2017

No description provided.

@KodrAus

This comment has been minimized.

Copy link
Contributor

KodrAus commented Sep 18, 2017

Thanks @jedisct1!

This depends on mvdnes/spin-rs#42

@KodrAus

This comment has been minimized.

Copy link
Contributor

KodrAus commented Sep 25, 2017

This looks good to me. @Kimundi are we ok to merge this and push out a point release?

@KodrAus

This comment has been minimized.

Copy link
Contributor

KodrAus commented Sep 26, 2017

Another fix for this I think would be #55 which removes the need for this feature flag.

@Kimundi Kimundi merged commit 4daab9f into rust-lang-nursery:master Sep 28, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Kimundi

This comment has been minimized.

Copy link
Contributor

Kimundi commented Sep 28, 2017

Looks good, thanks!

@joshlf

This comment has been minimized.

Copy link

joshlf commented Sep 28, 2017

Looks like this might not be sufficient - since the version of spin that's required is just 0.4, existing Cargo.lock files with 0.4.5 or below will still cause breakage because spin only fixed this issue in 0.4.6.

@sfackler

This comment has been minimized.

Copy link
Member

sfackler commented Sep 28, 2017

It seems pretty expected that people may have to update dependencies to fix bugs?

@joshlf

This comment has been minimized.

Copy link

joshlf commented Sep 28, 2017

Well right now, this will just show itself as a compilation failure - it wouldn't be obvious that updating to a newer version would fix things. If we changed the dependency to spin = 0.4.6, then it would show itself as a failure to resolve dependencies, which would make it very obvious what needed to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.