Skip to content

/lazy-static.rs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0 release #91

Merged
merged 2 commits into from Nov 29, 2017

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Kimundi @KodrAus
@Kimundi
Copy link
Contributor

Kimundi commented Nov 20, 2017

This PR finally stabilizes this crate as version 1.0!
@Kimundi
Make the 1.0 release
Loading status checks…
857d1c7
@KodrAus

This comment has been minimized.

Sign in to view
Copy link
Contributor

KodrAus commented Nov 20, 2017

Woohoo! Is it safe to assume changes to the API behind the nightly feature aren't being SemVer tracked, since we might be forced to tweak them in breaking ways? Maybe we should mention that in the readme somewhere.
@Kimundi

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

Kimundi commented Nov 20, 2017 •
edited

Ah, good point, I never even considered that they might be taken as stable parts of the API.

Hm, given that the nightly feature lives outside the module tree, where is the usual place to document stuff like this again?

@Kimundi Kimundi force-pushed the release_v1.0 branch 2 times, most recently from a1c7c91 to 4fa30bd Nov 20, 2017

@Kimundi Kimundi force-pushed the release_v1.0 branch from 4fa30bd to ad4ad8e Nov 20, 2017

@Kimundi

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

Kimundi commented Nov 20, 2017

Alright, I added some docs about the two features, and also cleaned up doc and metadata stuff I seem to have messed up in some recent changes.
@Kimundi

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

Kimundi commented Nov 29, 2017

Judging by the lack of further comments, I think it's time for the actual release now. :)

@Kimundi Kimundi merged commit ecabd81 into master Nov 29, 2017
4 checks passed

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Kimundi Kimundi deleted the release_v1.0 branch Nov 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.