Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport construction of `Record`s and `Metadata` #116
Comments
alexcrichton
added
the
help wanted
label
May 19, 2017
This comment has been minimized.
This comment has been minimized.
|
@alexcrichton Since
By:
It's not really important, but I think it may confuse users (including me!). |
sfackler
changed the title
Support construction of `LogRecord`s and `LogMetadata`
Support construction of `Record`s and `Metadata`
Jun 5, 2017
This comment has been minimized.
This comment has been minimized.
|
Fixed! |
This comment has been minimized.
This comment has been minimized.
|
I'll begin working on this!
Look ok? |
This comment has been minimized.
This comment has been minimized.
|
@omh1280 that looks reasonable to me. Methods should probably take |
This comment has been minimized.
This comment has been minimized.
|
I'm not sure how to give an example for creating a Does |
This comment has been minimized.
This comment has been minimized.
|
Yep |
omh1280
referenced this issue
Jun 20, 2017
Merged
Create builders for `Metadata`, `Record`, and `Level`. #200
This comment has been minimized.
This comment has been minimized.
|
I've submitted a PR for this! |
This comment has been minimized.
This comment has been minimized.
|
Thanks @omh1280! Sorry for the delay |
alexcrichton commentedMay 19, 2017
Testing and "shim loggers" typically want to do this so we should support these constructions! We probably want to have the construction go through builders to ensure that we can flexibly add more fields in the future.
I'm not tagging this issue as "easy" just yet as it's got some API design involved, but if we get a concrete design listed here I think it'd be great to tag this issue as "easy" afterwards for an implementation to come by.