Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove logger shutdown #117
Comments
alexcrichton
added
the
help wanted
label
May 19, 2017
This comment has been minimized.
This comment has been minimized.
|
Hi all, I'm interested in diving into this one, but I could use a little guidance. Is this about exposing a Thanks! |
This comment has been minimized.
This comment has been minimized.
|
All of the above! Removing shutdown allows https://github.com/rust-lang-nursery/log/blob/master/src/lib.rs#L264 and the related logic to go away. Flush is just a new method on |
sfackler
closed this
in
#196
Aug 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
alexcrichton commentedMay 19, 2017
This adds some complexity to the logger plus extra cost on all logger calls. In our discussion of this issue the review team also concluded that it would be prudent to maybe add a top-level flushing method to explicitly ensure that a common part of shutdown, flushing, can still be manually performed. Flushing would be a noop by default.