Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logger shutdown #117

Closed
alexcrichton opened this Issue May 19, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@alexcrichton
Copy link
Member

alexcrichton commented May 19, 2017

This adds some complexity to the logger plus extra cost on all logger calls. In our discussion of this issue the review team also concluded that it would be prudent to maybe add a top-level flushing method to explicitly ensure that a common part of shutdown, flushing, can still be manually performed. Flushing would be a noop by default.

@alexcrichton alexcrichton referenced this issue May 21, 2017

Closed

Tracking issue for log evaluation #150

36 of 38 tasks complete
@pittma

This comment has been minimized.

Copy link
Contributor

pittma commented Jun 1, 2017

Hi all,

I'm interested in diving into this one, but I could use a little guidance. Is this about exposing a flush, or removing shutdown? Or, rather, is it about removing the state (and therefore the check) from the logger's state machine?

Thanks!

@sfackler

This comment has been minimized.

Copy link
Member

sfackler commented Jun 1, 2017

All of the above! Removing shutdown allows https://github.com/rust-lang-nursery/log/blob/master/src/lib.rs#L264 and the related logic to go away. Flush is just a new method on Log with a default implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.