Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove env_logger from this repository #145
Comments
alexcrichton
added
the
help wanted
label
May 19, 2017
This comment has been minimized.
This comment has been minimized.
sebasmagri
commented
Jul 6, 2017
•
|
Hey @alexcrichton, I've started to work on this split at sebasmagri/env_logger. I'll review the features mentioned in the evaluation thread and check out the API guidelines for the new repo. For now, I'm pointing it to |
This comment has been minimized.
This comment has been minimized.
sebasmagri
commented
Jul 6, 2017
|
@alexcrichton @sfackler by @brson suggestion, I've added you guys as collaborators in the new repo. |
This comment has been minimized.
This comment has been minimized.
|
Thanks @sebasmagri! |
This comment has been minimized.
This comment has been minimized.
jethrogb
commented
Jul 12, 2017
|
How do you want to handle outstanding PRs? |
This comment has been minimized.
This comment has been minimized.
sebasmagri
commented
Jul 12, 2017
|
@jethrogb ideally the changes should be resubmitted to the new repo... Can you please point me to those? |
This comment has been minimized.
This comment has been minimized.
|
Seems like we need to make some decisions about this - are we going to do a handover here, and how? If we're confident doing it then it seems like we should maybe land the outstanding PRs, remove env_logger from this repo, and maybe reimport that state into @sebasmagri's. |
This comment has been minimized.
This comment has been minimized.
sebasmagri
commented
Aug 4, 2017
|
For the record, the open PRs that touch There has no been further changes to |
This comment has been minimized.
This comment has been minimized.
|
I would love to give env-logger over to a motivated maintainer. |
This comment has been minimized.
This comment has been minimized.
mjkillough
commented
Aug 21, 2017
|
#200 has also made a small change to env_logger in this repo and #196 has now been merged. I've made both changes to the forked env_logger here: sebasmagri/env_logger#15. |
This comment has been minimized.
This comment has been minimized.
|
@sebasmagri have you logged into crates.io yet? I tried adding you as an owner but it said you weren't registered :( |
This comment has been minimized.
This comment has been minimized.
sebasmagri
commented
Aug 21, 2017
|
@alexcrichton I hadn't, you should be able to find me now. |
This comment has been minimized.
This comment has been minimized.
|
@sebasmagri ok you're added as an owner, as soon as everything's sorted away I think we can just have a PR to remove it from this repo. |
KodrAus
closed this
in
#224
Sep 17, 2017
KodrAus
reopened this
Sep 17, 2017
This comment has been minimized.
This comment has been minimized.
|
I'll leave this open until we've got the current set of PRs against |
alexcrichton commentedMay 19, 2017
•
edited by KodrAus
Let's find a suitable maintainer and move it out of the
logrepository itself. While still a high quality logger that we'd likely want to recommend, it may benefit from spreading out the maintenance burden! Tons of possible features were mentioned forenv_loggeron the evaluation thread and may wish to make their way to the new repository.EDIT
PRs that need to be resubmitted to the new repo: