Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove env_logger from this repository #145

Closed
alexcrichton opened this Issue May 19, 2017 · 13 comments

Comments

Projects
None yet
7 participants
@alexcrichton
Copy link
Member

alexcrichton commented May 19, 2017

Let's find a suitable maintainer and move it out of the log repository itself. While still a high quality logger that we'd likely want to recommend, it may benefit from spreading out the maintenance burden! Tons of possible features were mentioned for env_logger on the evaluation thread and may wish to make their way to the new repository.

EDIT

PRs that need to be resubmitted to the new repo:

@alexcrichton alexcrichton referenced this issue May 21, 2017

Closed

Tracking issue for log evaluation #150

36 of 38 tasks complete
@sebasmagri

This comment has been minimized.

Copy link

sebasmagri commented Jul 6, 2017

Hey @alexcrichton, I've started to work on this split at sebasmagri/env_logger.

I'll review the features mentioned in the evaluation thread and check out the API guidelines for the new repo.

For now, I'm pointing it to log's git repo since there where some breaking changes in its enums. What would be the plan in log's side to make a stable dep for env_logger?

@sebasmagri

This comment has been minimized.

Copy link

sebasmagri commented Jul 6, 2017

@alexcrichton @sfackler by @brson suggestion, I've added you guys as collaborators in the new repo.
Is there any particular improvement that should be done for it?

@brson

This comment has been minimized.

Copy link
Contributor

brson commented Jul 6, 2017

Thanks @sebasmagri!

@jethrogb

This comment has been minimized.

Copy link

jethrogb commented Jul 12, 2017

How do you want to handle outstanding PRs?

@sebasmagri

This comment has been minimized.

Copy link

sebasmagri commented Jul 12, 2017

@jethrogb ideally the changes should be resubmitted to the new repo... Can you please point me to those?

@brson

This comment has been minimized.

Copy link
Contributor

brson commented Jul 15, 2017

Seems like we need to make some decisions about this - are we going to do a handover here, and how?

If we're confident doing it then it seems like we should maybe land the outstanding PRs, remove env_logger from this repo, and maybe reimport that state into @sebasmagri's.

cc @sfackler @alexcrichton

@sebasmagri

This comment has been minimized.

Copy link

sebasmagri commented Aug 4, 2017

For the record, the open PRs that touch env_logger are #203 (though this is already open in the new repo as well), #196 which is just about adding a noop flush method to env_logger's Logger, and #113 which is not yet defined as per @dtolnay's feedback.

There has no been further changes to env_logger since I transplanted it.

@sfackler

This comment has been minimized.

Copy link
Member

sfackler commented Aug 10, 2017

I would love to give env-logger over to a motivated maintainer.

@mjkillough

This comment has been minimized.

Copy link

mjkillough commented Aug 21, 2017

#200 has also made a small change to env_logger in this repo and #196 has now been merged. I've made both changes to the forked env_logger here: sebasmagri/env_logger#15.

@alexcrichton

This comment has been minimized.

Copy link
Member Author

alexcrichton commented Aug 21, 2017

@sebasmagri have you logged into crates.io yet? I tried adding you as an owner but it said you weren't registered :(

@sebasmagri

This comment has been minimized.

Copy link

sebasmagri commented Aug 21, 2017

@alexcrichton I hadn't, you should be able to find me now.

@alexcrichton

This comment has been minimized.

Copy link
Member Author

alexcrichton commented Aug 21, 2017

@sebasmagri ok you're added as an owner, as soon as everything's sorted away I think we can just have a PR to remove it from this repo.

@KodrAus

This comment has been minimized.

Copy link
Contributor

KodrAus commented Sep 17, 2017

I'll leave this open until we've got the current set of PRs against env_logger ported over (updated OP).

@KodrAus KodrAus closed this Sep 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.