Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upImplemented common traits for LogLevel, LogLevelFilter, LogMetadata, … #151
Conversation
omh1280
referenced this pull request
May 20, 2017
Closed
Implement common traits for more types #144
This comment has been minimized.
This comment has been minimized.
dtolnay
merged commit eb90d0e
into
rust-lang-nursery:master
May 20, 2017
omh1280
deleted the
omh1280:impl_traits
branch
May 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
omh1280 commentedMay 20, 2017
•
edited
Added traits to common structs and enums, according to #144. My first pr--did I do this right? :)
Ottavio