Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upReplaced my_logger with env_logger in docs #153
Conversation
omh1280
referenced this pull request
May 20, 2017
Closed
Use env_logger instead of my_logger in doc example #120
dtolnay
reviewed
May 20, 2017
src/lib.rs
Outdated
| //! | ||
| //! env_logger::init().unwrap(); | ||
| //! | ||
| //! // Set the RUST_LOG level prior to running the binary |
This comment has been minimized.
This comment has been minimized.
dtolnay
May 20, 2017
Member
This sounds like it says the next line info!("starting up") sets the RUST_LOG level. Also RUST_LOG contains more than just the level.
I would prefer to put this above the previous line and say something like:
// Select env_logger, one possible logger implementation
// (see https://doc.rust-lang.org/log/env_logger/index.html)
env_logger::init().unwrap();
This comment has been minimized.
This comment has been minimized.
dtolnay
merged commit 1e0a7fd
into
rust-lang-nursery:master
May 20, 2017
omh1280
deleted the
omh1280:env_logger_doc
branch
May 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
omh1280 commentedMay 20, 2017
Fixes #120
Ottavio