Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd an error type to FromStr impls #156
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
I would merge to master along with a note in Cargo.toml. publish = false # this branch contains breaking changes |
alexcrichton
referenced this pull request
May 21, 2017
Closed
FromStr impls for LogLevel, LogLevelFilter use () as error type #119
This comment has been minimized.
This comment has been minimized.
|
Removed the |
This comment has been minimized.
This comment has been minimized.
|
Thanks @nivkner! We'll take it from here and figure out the best way to land this with other breaking changes to the |
This comment has been minimized.
This comment has been minimized.
|
Seems fine to merge to master - we can always cut an 0.3.x branch if we need more releases from that version. |
This comment has been minimized.
This comment has been minimized.
|
@nivkner any reason these messages are slightly different? I would prefer to pick one or the other. |
dtolnay
merged commit de11f39
into
rust-lang-nursery:master
May 24, 2017
This comment has been minimized.
This comment has been minimized.
|
Ah, this matches all of the existing error messages. I filed #166 to follow up. |
nivkner
deleted the
nivkner:parse-error
branch
Jun 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
nivkner commentedMay 20, 2017
Fixes #119