Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd serde impls to LogLevel and LogLevelFilter #161
Conversation
This comment has been minimized.
This comment has been minimized.
|
Thanks! Could you also add some CI configuration to test this on Travis/AppVeyor? Also, I think the dependency here is safe to just be |
This comment has been minimized.
This comment has been minimized.
|
@aergonaut are you still working on this or would you need to hand it off to someone else? |
This comment has been minimized.
This comment has been minimized.
|
I would still like to work on this! I will try to come back to it by the end of the week. |
This comment has been minimized.
This comment has been minimized.
|
No problem, let us know if you get stuck. |
aergonaut
added some commits
May 21, 2017
aergonaut
force-pushed the
aergonaut:serde-impls
branch
from
bbf4309
to
000a21b
May 30, 2017
This comment has been minimized.
This comment has been minimized.
|
@dtolnay @alexcrichton I think this is ready now! I added |
aergonaut commentedMay 21, 2017
Fixes #143
Adds
serdeas an optional dependency and puts theSerializeandDeserializetraits behindcfg_attr. I wasn't sure what version I should specify. 1.0.7 was the latest when I checked, but maybe it's too specific? Would>= 1.0be better?Saw the post on the internals forum, wanted to help out!