Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRemoved type "stuttering" #162
Conversation
dtolnay
approved these changes
May 23, 2017
|
Thanks! This is indeed very thorough. In my opinion the env_logger ones should change as well—in a separate PR. |
dtolnay
merged commit fbd57e4
into
rust-lang-nursery:master
May 23, 2017
This was referenced May 24, 2017
omh1280
deleted the
omh1280:stutter
branch
May 25, 2017
This comment has been minimized.
This comment has been minimized.
|
@omh1280 Does this mean this kind of examples is obsolete: https://brson.github.io/rust-cookbook/logging.html#log-messages-with-a-custom-logger ? |
omh1280
referenced this pull request
Jul 24, 2017
Closed
env_logger::Builder example does not compile #209
bridger-herman
added a commit
to bridger-herman/sawtooth-core
that referenced
this pull request
Jun 6, 2018
bridger-herman
added a commit
to bridger-herman/sawtooth-core
that referenced
this pull request
Jun 7, 2018
bridger-herman
added a commit
to bridger-herman/sawtooth-core
that referenced
this pull request
Jun 7, 2018
bridger-herman
added a commit
to bridger-herman/sawtooth-core
that referenced
this pull request
Jun 11, 2018
agunde406
added a commit
to hyperledger/sawtooth-core
that referenced
this pull request
Jun 11, 2018
danintel
added a commit
to danintel/sawtooth-core
that referenced
this pull request
Jun 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
omh1280 commentedMay 22, 2017
Fixes #142
Types like
LogLevelhave just becomeLevel.The affected enums, structs, and functions include:
LogLevelLogLevelFilterLogRecordLogMetadataLogLocationMaxLogLevelFilter(nowMaxLevelFilter)max_log_level()(nowmax_level())I changed only the parts of
env_loggerthat referencelog. Should I update its types as well? (LikeLogBuilderandLogTarget?)The docs compile correctly and hyperlinking isn't broken. It's entirely possible I've missed something, but I've tried to be thorough.
Ottavio