Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded keywords to log and env_logger Cargo.toml #163
Conversation
dtolnay
reviewed
May 23, 2017
|
These all mean the same thing. I would prefer to pick only one. Hopefully the ecosystem will standardize on whichever one we select here. I recommend |
budziq
force-pushed the
budziq:keywords
branch
from
3c7de66
to
0d90b34
May 24, 2017
This comment has been minimized.
This comment has been minimized.
|
done |
dtolnay
merged commit 8c08ef5
into
rust-lang-nursery:master
May 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
budziq commentedMay 23, 2017
Hi,
I've added
keywords = ["logger", "log", "logging"]to both log and env_logger.These are the best I could came up with.
resolves #140