make error description consistent with display

[nivkner]

Fixes #166

[budziq]

Hi @nivkner
Your PR fails due to tests::test_error_trait not being updated with the new description

[nivkner]

Fixed, thanks.

[dtolnay]

Could you refactor this to make sure the messages stay in sync? Maybe something like this:

fn fmt(&self, formatter: &mut fmt::Formatter) -> fmt::Result {
    formatter.write_str(self.description())
}

[dtolnay]

Could you refactor this to make sure the messages stay in sync? Maybe something like this:

fn fmt(&self, formatter: &mut fmt::Formatter) -> fmt::Result {
    formatter.write_str(self.description())
}

[nivkner]

nightly only problem with use statements. Is that a change I should know about?

[dtolnay]

Oh 🦊 this is failing in the no_std build because Display is implemented but the #[cfg(feature = "use_std")] line means Error is not implemented, so Display cannot get the description from Error.

How about private statics instead? Used by both Display and Error.

static SET_LOGGER_ERROR: &'static str = "...";

[dtolnay]

Nice, thank you!

[dtolnay]

Nice, thank you!