Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upupdate html_root_url for env_logger #173
Conversation
morrme
added some commits
May 24, 2017
This comment has been minimized.
This comment has been minimized.
|
Yes. I reopened #139 to track that. |
dtolnay
approved these changes
May 24, 2017
dtolnay
merged commit 7bd1480
into
rust-lang-nursery:master
May 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
morrme commentedMay 24, 2017
Closes: #141
@dtolnay there is a
documentationline inenv/Cargo.tomlhere : https://github.com/morrme/log/blob/issue141/env/Cargo.toml#L7Should that be updated as well?