Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upReduce "stuttering" in env_logger symbols #174
Conversation
budziq
added some commits
May 24, 2017
dtolnay
merged commit 50ce9a6
into
rust-lang-nursery:master
May 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
budziq commentedMay 24, 2017
•
edited
I did not know if private symbols LogDirective and parse_logging_spec* should also be renamed so this PR is split with private symbols in second commit.
Both unit and doc tests pass, hopefully sed did not miss anything ;)
Hi @dtolnay is this roughly in line with what you've had in mind in #162 (review) ?
resolves: #169