Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRecord Doc Improvements #178
Conversation
jehiggs
added some commits
May 27, 2017
dtolnay
reviewed
May 27, 2017
src/lib.rs
Outdated
| /// } | ||
| /// ``` | ||
| /// | ||
| /// [`log`]: trait.Log.html#method.log |
This comment has been minimized.
This comment has been minimized.
dtolnay
May 27, 2017
Member
Markdown links are case insensitive so you can't have both [`log`] and [`Log`]. How about the following?
bla bla [`log`][method.log] method
[method.log]: trait.Log.html#method.log
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Thank you! |
dtolnay
merged commit 1389e2d
into
rust-lang-nursery:master
May 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jehiggs commentedMay 27, 2017
This addresses the doc improvements suggested by #129 for the Record structure.
Let me know if there's anything missing or anything that can be improved!