Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate docs for Location struct and add example #179
Conversation
dtolnay
reviewed
May 27, 2017
src/lib.rs
Outdated
| /// accessed directly. | ||
| /// | ||
| /// [`log!`]: macro.log!.html |
This comment has been minimized.
This comment has been minimized.
dtolnay
May 27, 2017
Member
macro.log!.html redirects to macro.log.html so you would save the user a redirect by pointing to macro.log.html directly.
dtolnay
merged commit 95dbcf7
into
rust-lang-nursery:master
May 27, 2017
This comment has been minimized.
This comment has been minimized.
|
Great work! Next time please include "Fixes #127" in the comment when you open the PR so GitHub auto-closes the right issue when the PR is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jehiggs commentedMay 27, 2017
This provides the doc updates as suggested in #127.
I realize I've accidentally introduced some whitespace changes; I can revert these if required.