Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd serde impls for LogLevel/LogLevelFilter #181
Conversation
dtolnay
merged commit 31f55c0
into
rust-lang-nursery:master
May 30, 2017
dtolnay
reviewed
May 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
meven commentedMay 29, 2017
•
edited
Pull-request for:
#143
I am not entirely sure about the format of serialization I have used.
It is also my first contribution, so any feedback is welcome.
To run tests, use:
cargo test --features "use_serde"It misses documentation as of now, but I will add it before merging, I just would like some validation of the code first.