Skip to content

/log

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max_level doc improvements #185

Merged
merged 1 commit into from May 30, 2017

Conversation

Reviewers

@dtolnay dtolnay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@rap2hpoutre @dtolnay
@rap2hpoutre
Copy link
Contributor

rap2hpoutre commented May 30, 2017

see: #134
@rap2hpoutre
max_level doc improvements
Loading status checks…
c155655
@rap2hpoutre

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

rap2hpoutre commented May 30, 2017

Or maybe #125 I'm not sure anymore. Anyway, it improves max_level docs!
@dtolnay

dtolnay approved these changes May 30, 2017
View changes

Copy link
Member

dtolnay left a comment

Thank you. This looks good to me. The MaxLevel could also be linked but we can follow up separately.

@dtolnay dtolnay merged commit ec2e44d into rust-lang-nursery:master May 30, 2017
2 checks passed

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rap2hpoutre

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

rap2hpoutre commented Jun 5, 2017 •
edited

@dtolnay Thanks!

You wrote:

The MaxLevel could also be linked but we can follow up separately.

Ok, I can do this!

The documentation says:

The maximum log level is set by the MaxLevel token passed to loggers.

Should it refer to set_logger? or MaxLevelFilter set method?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.