Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRename set_logger_raw to try_set_logger_raw #208
Conversation
alisha17
force-pushed the
alisha17:set_logger_raw
branch
2 times, most recently
from
d6e4c63
to
26ea565
Jul 16, 2017
This comment has been minimized.
This comment has been minimized.
|
Looks good to me, thanks! @sfackler do you agree with the rename here? |
This comment has been minimized.
This comment has been minimized.
|
Seems reasonable to me, but it needs a rebase. |
alisha17
force-pushed the
alisha17:set_logger_raw
branch
2 times, most recently
from
50c7de4
to
2587e32
Aug 17, 2017
This comment has been minimized.
This comment has been minimized.
|
Rebased @sfackler |
alisha17
force-pushed the
alisha17:set_logger_raw
branch
from
80025e9
to
308e6f3
Aug 17, 2017
This comment has been minimized.
This comment has been minimized.
|
Is this good to merge now? |
This comment has been minimized.
This comment has been minimized.
|
Yep! |
sfackler
merged commit 20f1c82
into
rust-lang-nursery:master
Sep 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
alisha17 commentedJul 16, 2017
Fixes #204