Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow `#[macro_use(info)]` to import individual macros. #220
Conversation
This comment has been minimized.
This comment has been minimized.
|
Looking at the proposal in #218, it may be that the macros will soon become more complex, making the code duplication a lot more painful... |
This comment has been minimized.
This comment has been minimized.
|
Thanks for doing this @mjkillough! My personal feeling on this is that we should hold off for now, assuming we want to solve this problem this way, so there's less friction to exploring structured logging. @sfackler might have other ideas though. |
This comment has been minimized.
This comment has been minimized.
|
Yeah, I'd be a bit worried about the implementations desynchronizing, especially as the macros become more complicated. Making a script to generate the module is one option. |
This comment has been minimized.
This comment has been minimized.
|
Yep, that's fair enough! I'll close this one. |
mjkillough
closed this
Oct 2, 2017
mjkillough
deleted the
mjkillough:macro_use
branch
Oct 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
mjkillough commentedAug 22, 2017
Inline logic from
log!intoerror!/warn!/....Alternatively, we could create a helper function which all macros call (passing in the output of
file!/line!/etc.), but this helper function would need to be in the public API oflog, which is a bit ugly.After playing around with alternatives, I figured I may as well open a PR for this option (which I consider to be the least of all evils). If the duplication is undesirable, then feel free to close! :)
Fixes #54.