Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove env_logger crate #224
Conversation
KodrAus
requested a review
from
sfackler
Sep 17, 2017
KodrAus
force-pushed the
KodrAus:chore/remove-env-logger
branch
from
03de104
to
5516ef0
Sep 17, 2017
KodrAus
force-pushed the
KodrAus:chore/remove-env-logger
branch
from
5516ef0
to
cb86d3a
Sep 17, 2017
sfackler
approved these changes
Sep 17, 2017
KodrAus
merged commit 1895c64
into
rust-lang-nursery:master
Sep 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
KodrAus commentedSep 17, 2017
Closes #145
envfolder and update links to the crate's new home where appropriate.env_loggerexample from the docs, but left the example in the readme and added the list of other logger implementations. I'd also happily turn this into a link to the docs so we don't have two lists to maintain.Any other thoughts or things that need to be done for this?
cc: @sebasmagri