Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUse a &'static Log rather than raw pointer #228
Conversation
This comment has been minimized.
This comment has been minimized.
|
We're now temptingly close to being entirely no_std. It's kind of unfortunate we don't have a |
alexcrichton
merged commit 2901ed5
into
rust-lang-nursery:master
Sep 28, 2017
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
I wonder, would this enable us to turn off the |
sfackler
deleted the
sfackler:no-raw-ptr
branch
Sep 28, 2017
This comment has been minimized.
This comment has been minimized.
|
Yeah - that's what I'm kind of wondering. Loggers that have state are going to want the Box interface but they can opt into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
sfackler commentedSep 28, 2017
This allows us to make try_set_logger_raw a safe function. It turns out
that every example dealing with that function was violating the static
lifetime requirement. Fun!
r? @alexcrichton