Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upIntegrate ACE for editing #247
Comments
steveklabnik
added
the
Type: Enhancement
label
Apr 5, 2017
azerupi
added
A-JavaScript
S-Experiment
T-Enhancement
and removed
Type: Enhancement
labels
May 15, 2017
This comment has been minimized.
This comment has been minimized.
|
If ACE is integrated, it should be optional with a key in the config. It's too large of a dependency to impose on all users. |
This comment has been minimized.
This comment has been minimized.
|
I've been poking at trying to add Ace to playpens for a bit. Since this is about adding features to mdBook, it would help knowing what mdBook's overall goals are, and this is my first time looking at this repo. @azerupi does mdBook have interest in implementing editing functionality in the general case? I've seen what appears to be a dormant flag
mdBook currently has highlight.js as a dependency, which is not too light (although it can be reduced to basically nothing if a version for just Rust is grabbed). Ace is heavier, but would make highlight.js unnecessary. Right now, Ace will not work inside playpens because highlight.js seems to grab events on code blocks. |
This comment has been minimized.
This comment has been minimized.
As an opt-in feature, yes. It is not something I want to force on all users if they don't need it.
Indeed, in the long run I was planning to take a look at syntect as an alternative in order to move syntax highlighting to the book generation phase. But that is not for right now. |
steveklabnik commentedApr 5, 2017
This is the last thing needed to get Rust By Example over to mdbook.
I did some work on this today, and it seems like ACE clashes with something else we're doing; the divs just don't show up.