Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the missing features for Rust By Example #308

Open
azerupi opened this Issue Jun 1, 2017 · 5 comments

Comments

Projects
None yet
4 participants
@azerupi
Copy link
Collaborator

azerupi commented Jun 1, 2017

This issue serves to track the remaining issues before RBE can be ported over to mdBook.

Blockers

  • #247 - Editable code snippets (through ACE?)
  • Test code snippets (maybe the existing test command is sufficient, but probably not)

Nice to have

  • Check for dead links
  • Good error message when a file to include is not present

If I missed anything or there are other requirements that need to be added, feel free to post them below. I will update this post.

\cc @mdinger @projektir @steveklabnik

@azerupi azerupi added the M-Discussion label Jun 1, 2017

@steveklabnik

This comment has been minimized.

Copy link
Member

steveklabnik commented Jun 1, 2017

Test code snippets (maybe the existing test command is sufficient, but probably not)

I have a feeling that it is, personally.

The requirements look good to me 👍

@azerupi azerupi added this to the Rust By Example milestone Jun 1, 2017

@mdinger

This comment has been minimized.

Copy link
Contributor

mdinger commented Jun 1, 2017

I also approve

@projektir

This comment has been minimized.

Copy link
Contributor

projektir commented Jun 21, 2017

Test code snippets (maybe the existing test command is sufficient, but probably not)

I've tried out mdbook test and it seems to be working fine for code blocks.

@projektir

This comment has been minimized.

Copy link
Contributor

projektir commented Jun 24, 2017

I've made two issues for the nice to haves and plan to work on them unless anyone objects. I think they're straightforward enough to implement, useful for mdBook in general, and worth doing to make @mdinger's life easier. 😄

Also, @azerupi, nitpick, but in this line: "#247 - Editable code snippets (through ACE?)", the ACE link points back to this issue, it should probably point to https://ace.c9.io/.

@azerupi

This comment has been minimized.

Copy link
Collaborator Author

azerupi commented Jun 24, 2017

the ACE link points back to this issue

Oh yes, my bad! I forgot the link 😊

I've made two issues for the nice to haves and plan to work on them unless anyone objects.

I am certainly not going to object 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.