Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention syntax ambiguity for eRFC 2947. #437

merged 2 commits into from Oct 3, 2018


None yet
3 participants
Copy link

davidtwco commented Sep 30, 2018

Show resolved Hide resolved src/expressions/ Outdated
Copy link

Havvy left a comment

A couple small things on wording. Actual content looks good to me.

Show resolved Hide resolved src/expressions/ Outdated
@@ -111,6 +111,27 @@ match EXPR {

If the expression is a [lazy boolean operator expression][_LazyBooleanOperatorExpression_] then
this is a error as it is ambiguous which is problematic for the implementation

This comment has been minimized.


Havvy Oct 2, 2018


I'd leave out the "which is problematic". Just state it's ambiguous with a planned future change in the language.

This comment has been minimized.


davidtwco Oct 3, 2018

Author Member

Changed this.



This comment was marked as outdated.

Copy link
Member Author

davidtwco commented Oct 3, 2018

Oops, let me remove the fixup! commit.

davidtwco added some commits Sep 30, 2018


This comment has been minimized.

Copy link

Centril commented Oct 3, 2018


@Centril Centril merged commit 9214ce6 into rust-lang-nursery:master Oct 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed

@davidtwco davidtwco deleted the davidtwco:erfc-2947-documentation branch Oct 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.