Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upadd a build script that complains about wrong nightly versions #2716
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
phansch
May 3, 2018
Collaborator
I suppose that this is the build script, right? https://github.com/SergioBenitez/Rocket/blob/master/lib/build.rs
Oh and this works using the cargo build script feature, nice!
phansch
commented
May 3, 2018
•
edited
Edited 1 time
-
phansch
edited May 3, 2018 (most recent)
edited
-
May 3, 2018 (most recent)
|
I suppose that this is the build script, right? https://github.com/SergioBenitez/Rocket/blob/master/lib/build.rs Oh and this works using the cargo build script feature, nice! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
oli-obk
May 3, 2018
Collaborator
jup. we should probably read the version numbers from an extra file with include_str (instead of hardcoding in the build.rs) so we can just generate the current version number via the update_lints python script
|
jup. we should probably read the version numbers from an extra file with include_str (instead of hardcoding in the build.rs) so we can just generate the current version number via the update_lints python script |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
phansch
May 3, 2018
Collaborator
Going to take a look at this now and hope to have something merge-ready by next week
|
Going to take a look at this now and hope to have something merge-ready by next week |
oli-obk commentedMay 2, 2018
Similar to what rocket has. Since we don't know what future rustc versions are OK, we just emit an error message if the rustc version is too old