New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FP in `fn_to_numeric_cast_with_truncation` #3279

Merged
merged 1 commit into from Oct 7, 2018

Conversation

Projects
None yet
2 participants
@phansch
Collaborator

phansch commented Oct 7, 2018

We only want this lint to check casts to numeric, as per the lint title.
Rust already has a built-in check for all other casts here.

Fixes #3275

@phansch

This comment has been minimized.

Show comment
Hide comment
@phansch

phansch Oct 7, 2018

Collaborator
Collaborator

phansch commented Oct 7, 2018

Fix FP in `fn_to_numeric_cast_with_truncation`
We only want this lint to check casts to numeric, as per the lint title.
Rust already has a built-in check for all other casts
[here][rust_check].

[rust_check]: https://github.com/rust-lang/rust/blob/5472b0718f286266ab89acdf234c3552de7e973c/src/librustc_typeck/check/cast.rs#L430-L433
@Manishearth

This comment has been minimized.

Show comment
Hide comment
@Manishearth

Manishearth Oct 7, 2018

Collaborator

We don't have bors on this repo

Collaborator

Manishearth commented Oct 7, 2018

We don't have bors on this repo

@Manishearth Manishearth merged commit 5dcb90e into rust-lang-nursery:master Oct 7, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@phansch phansch deleted the phansch:fix_fp_in_fn_to_numeric_cast_with_truncation branch Oct 7, 2018

@phansch

This comment has been minimized.

Show comment
Hide comment
@phansch

phansch Oct 7, 2018

Collaborator

Yea, I just saw https://app.bors.tech/repositories/3993 and was wondering if it was already working. Sorry for the spam ❤️

Collaborator

phansch commented Oct 7, 2018

Yea, I just saw https://app.bors.tech/repositories/3993 and was wondering if it was already working. Sorry for the spam ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment