Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Travis windows build #3300

Merged
merged 3 commits into from Oct 12, 2018
Merged

Add Travis windows build #3300

merged 3 commits into from Oct 12, 2018

Conversation

phansch
Copy link
Member

@phansch phansch commented Oct 12, 2018

AppVeyor has problems with permissions because projects are tied to a person and not a GitHub organization. It would be nice to switch to Travis CI when it works.

See https://blog.travis-ci.com/2018-10-11-windows-early-release/

  • stable release in Q2 of 2019
  • runs a git bash shell

@phansch
Copy link
Member Author

phansch commented Oct 12, 2018

I don't expect it to work right away. Let's see what fails.

@phansch phansch force-pushed the travis_windows branch 6 times, most recently from 3944b72 to 9ac79a7 Compare October 12, 2018 05:50
Until the remaining issues are fixed. This also enabled `fast_finish`.
It will finish even if the windows build is still running.
@phansch
Copy link
Member Author

phansch commented Oct 12, 2018

Ok, this is as far as it can get currently. I enabled allow_failure for the windows build for now, since it fails because of https://travis-ci.community/t/rust-error-could-not-compile-winapi/268. I also made sure that the markdown linter only runs on linux, because nvm/npm were not available on windows.

IMO this can be merged since it's something that Travis has to fix.

Copy link
Contributor

@oli-obk oli-obk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know your language is easy to use if Travis chooses it as one of the three initially supported on windows

Because:

* There's no need to run it on more than one platform
* It doesn't work on windows
@phansch phansch merged commit e03a06b into rust-lang:master Oct 12, 2018
@phansch phansch deleted the travis_windows branch October 12, 2018 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants