Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upCookbook 1.0 #414
Comments
budziq
modified the milestones:
impl period,
CookBook 1.0
May 16, 2018
This comment has been minimized.
This comment has been minimized.
|
I fully agree with the idea! Ive created a milestone to aggregate the issues that most likely should be addressed before 1.0 release. I'd propose to also address: optionally: Not sure if we will be ready for 1.0 then but it should be a good approximation to present to the libs team :) |
This comment has been minimized.
This comment has been minimized.
|
I've added all those to the original comment. Let's do this thing! |
This comment has been minimized.
This comment has been minimized.
|
I think we are only missing the updates to the CONTRIBUTING and PR Template to support this purposed 1.0 rewrite. |
This comment has been minimized.
This comment has been minimized.
|
Actually, we need to determine if the Cookbook will rely on a git version of mdbook or wait until 1.8 drops. Either way, build scripts and README needs to be updated. |
This comment has been minimized.
This comment has been minimized.
|
In order to build mdbook from master on rust 1.27, rust-lang/cargo#5627 dictates specifying the version (--version 0.1.8-alpha.0) which is brittle. I want to wait until 0.1.8 lands unless rust 1.28 stabilizes first. |
This comment has been minimized.
This comment has been minimized.
|
0.1.8 landed this morning, I built the branch successfully! |
This comment has been minimized.
This comment has been minimized.
|
I merged the Reorganize branch #404 |
This comment has been minimized.
This comment has been minimized.
|
Thanks for pushing this through the finish line @AndyGauge ! |
This comment has been minimized.
This comment has been minimized.
|
Our imaginary line in the sand is complete. |
AndyGauge commentedMay 16, 2018
•
edited
What will it take for us to call the cookbook 1.0?
First thing: A huge shout out to @budziq and the improvements he has made to the cookbook. I am continually impressed by your effort.
I want to draw a line in the sand that we can release the cookbook. What I think should be in scope of this release:
What I want to keep active (for post 1.0) is:
There are a few PRs that are sitting in the queue. It is going to take some effort to get them to merge after #404 lands. I'd be happy to finish the outstanding work on them and include them in a 1.0 release.
Here's the original discussion at ecosystem-wg.
I'd love some feedback on what you'd like to see done before stamping the Rust Cookbook 1.0