New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Extract unique Hashtag example. Fixes #242 #247

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@Phaiax
Contributor

Phaiax commented Jul 15, 2017

@budziq

Hi @Phaiax
The example looks really nice 👍 just some suggestions below to help the next reviewer.

some of the comments here are applicable also to #248

Show outdated Hide outdated src/basics.md
Show outdated Hide outdated src/basics.md
Show outdated Hide outdated src/basics.md
Show outdated Hide outdated src/basics.md
@budziq

Nearly perfect! just few more touches. Sorry the review slipped past me for quite some time

Show outdated Hide outdated src/basics.md
Show outdated Hide outdated src/basics.md
Show outdated Hide outdated src/basics.md
Show outdated Hide outdated src/basics.md

@Phaiax Phaiax changed the title from Add Extract unique Hashtag example to Add Extract unique Hashtag example. Fixes #242 Jul 23, 2017

@brson

This comment has been minimized.

Show comment
Hide comment
@brson

brson Jul 25, 2017

Contributor

I rebased and merged manually. Thanks @Phaiax

Contributor

brson commented Jul 25, 2017

I rebased and merged manually. Thanks @Phaiax

@brson brson closed this Jul 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment