Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd Replace text with named capture groups example. fixes #243 #248
Conversation
This comment has been minimized.
This comment has been minimized.
|
I stole this one from the regex crate |
Phaiax
force-pushed the
Phaiax:ex-regex-replace-named-243
branch
from
419f52f
to
1455be5
Jul 15, 2017
This comment has been minimized.
This comment has been minimized.
|
Hi @Phaiax thanks for all the submissions! Unfortunately I'll not be able to follow up with anything resembling review for the next two weeks due to holidays To answer your unspoken question, regex examples would go to basics section (atm the distinction between basics and app is quite arbitrary and this will change in the future) |
budziq
requested changes
Jul 16, 2017
| Replaces all occurences of the hyphenated british english date pattern `2013-01-15` with its equivalent slashed american english date pattern `01/15/2013`. | ||
| ``` |
This comment has been minimized.
This comment has been minimized.
budziq
Jul 16, 2017
Collaborator
please add
```rust
otherwise the testrunner will not compile nor run it.
budziq
referenced this pull request
Jul 16, 2017
Closed
added verify email and extract login example #249
Phaiax
force-pushed the
Phaiax:ex-regex-replace-named-243
branch
3 times, most recently
from
4681fc3
to
a95bf2c
Jul 22, 2017
budziq
requested changes
Jul 22, 2017
|
Almost perfect! I would only suggest to update PR description with also I would mention the key identifiers ( |
Phaiax
force-pushed the
Phaiax:ex-regex-replace-named-243
branch
from
a95bf2c
to
186ead1
Jul 23, 2017
Phaiax
changed the title
Add Replace text with named capture groups example. #243
Add Replace text with named capture groups example. fixes #243
Jul 23, 2017
This comment has been minimized.
This comment has been minimized.
|
I rebased and merged manually. Thanks @Phaiax |
Phaiax commentedJul 15, 2017
#243
I'm not sure about the category. (I put #242 into
basics, but app development seems better now^^)