Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Replace text with named capture groups example. fixes #243 #248

Closed

Conversation

Projects
None yet
3 participants
@Phaiax
Copy link
Contributor

Phaiax commented Jul 15, 2017

#243

I'm not sure about the category. (I put #242 into basics, but app development seems better now^^)

@Phaiax

This comment has been minimized.

Copy link
Contributor Author

Phaiax commented Jul 15, 2017

I stole this one from the regex crate

@Phaiax Phaiax force-pushed the Phaiax:ex-regex-replace-named-243 branch from 419f52f to 1455be5 Jul 15, 2017

@budziq

This comment has been minimized.

Copy link
Collaborator

budziq commented Jul 15, 2017

Hi @Phaiax thanks for all the submissions!

Unfortunately I'll not be able to follow up with anything resembling review for the next two weeks due to holidays 😞 . I may drop some comments when Im on mobile later and I've asked other maintainers to drop from time to time and look into the PR's.

To answer your unspoken question, regex examples would go to basics section (atm the distinction between basics and app is quite arbitrary and this will change in the future)

@budziq
Copy link
Collaborator

budziq left a comment

Hi @Phaiax nice work! just some quick comments from mobile to help out the next reviewer

  • this example would go into basics

also some of the comments in #247 are applicable.

src/app.md Outdated
Replaces all occurences of the hyphenated british english date pattern `2013-01-15` with its equivalent slashed american english date pattern `01/15/2013`.
```

This comment has been minimized.

@budziq

budziq Jul 16, 2017

Collaborator

please add

 ```rust 

otherwise the testrunner will not compile nor run it.

@Phaiax Phaiax force-pushed the Phaiax:ex-regex-replace-named-243 branch 3 times, most recently from 4681fc3 to a95bf2c Jul 22, 2017

@budziq
Copy link
Collaborator

budziq left a comment

Almost perfect! I would only suggest to update PR description with fixes #243 to autoclose the issue on merge.

also I would mention the key identifiers (replace_all) with links and docs about the capture groups.

@Phaiax Phaiax force-pushed the Phaiax:ex-regex-replace-named-243 branch from a95bf2c to 186ead1 Jul 23, 2017

@Phaiax Phaiax changed the title Add Replace text with named capture groups example. #243 Add Replace text with named capture groups example. fixes #243 Jul 23, 2017

@brson

This comment has been minimized.

Copy link
Contributor

brson commented Jul 25, 2017

I rebased and merged manually. Thanks @Phaiax

@brson brson closed this Jul 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.